Enhancement. Reactive api rest for get SVG #216 #217

davideduma · 2022-12-02T15:22:22Z

Signed-off-by: davideduma [email protected]

❤️

What this PR does / why we need it: Reactive api rest for get SVG

Special notes for reviewers:

Additional information (if needed):

Signed-off-by: davideduma <[email protected]>

tsurdilo · 2022-12-04T21:06:28Z

@davideduma thanks for the pr. can you give some more info on what it does?

tsurdilo · 2022-12-04T21:07:02Z

api_rest/mvnw

@@ -0,0 +1,316 @@
+#!/bin/sh


do we need this?

Good morning, yes that's right. the reason is beacause is a spring maven project.

tsurdilo · 2022-12-04T21:10:09Z

Think most of files are missing our copyright. please add

davideduma · 2022-12-05T19:41:05Z

@davideduma thanks for the pr. can you give some more info on what it does?

With this functionality. It is possible to get the SVG string through a API REST

davideduma · 2022-12-09T15:30:15Z

Think most of files are missing our copyright. please add

Please give me a couple examples. i dont undestand

tsurdilo · 2022-12-09T15:31:31Z

Hi, you can look at any source files in the repo, for example: https://github.com/serverlessworkflow/sdk-java/blob/main/api/src/main/java/io/serverlessworkflow/api/deserializers/AuthDefinitionDeserializer.java#L1-L15

Signed-off-by: davideduma <[email protected]>

sonatype-lift · 2022-12-09T19:02:19Z

api_rest/src/main/java/io/serverlessworkflow/reactive_api_rest/ServerlessWorkFlowResponse.java

+@Data
+@NoArgsConstructor
+@AllArgsConstructor
+@Builder(toBuilder = true)


MissingSummary: A summary fragment is required; consider using the value of the @return block as a summary fragment instead.

Suggested change

@Builder(toBuilder = true)

Returns {@code this}.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

this suggestion cannot be applied. The above line is required.

sonatype-lift · 2022-12-09T19:02:22Z

api_rest/src/main/java/io/serverlessworkflow/reactive_api_rest/RouterRest.java

+  /***
+   * Get image SVG from string.
+   * @param serverlessRequest
+   * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

fixed issue

sonatype-lift · 2022-12-09T19:02:24Z

api_rest/src/main/java/io/serverlessworkflow/reactive_api_rest/RouterRest.java

+
+  /***
+   * Get image SVG from string.
+   * @param serverlessRequest


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param serverlessRequest

*

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Fixed issue

Signed-off-by: davideduma <[email protected]>

davideduma · 2022-12-09T19:17:37Z

this suggestion cannot be applied. The above line is required.:

Signed-off-by: davideduma <[email protected]>

davideduma · 2022-12-12T14:11:52Z

Fixed issues sonatype

davideduma · 2022-12-26T14:01:29Z

Hi. Can you help me. This pull request still in progress. Thanks!

davideduma · 2022-12-26T14:02:55Z

Hi. Can you help me. This pull request still in progress. Thanks!

Only Awaiting approval to owner.

Enhancement. Reactive api rest for get SVG serverlessworkflow#216

a178c04

Signed-off-by: davideduma <[email protected]>

davideduma requested a review from tsurdilo as a code owner December 2, 2022 15:22

tsurdilo reviewed Dec 4, 2022

View reviewed changes

Add comments copyright apache license

f7e3d16

Signed-off-by: davideduma <[email protected]>

sonatype-lift bot reviewed Dec 9, 2022

View reviewed changes

Add susuggestion sonatype bot

889c952

Signed-off-by: davideduma <[email protected]>

Fixed suggest sonatype

11ea976

Signed-off-by: davideduma <[email protected]>

davideduma requested a review from tsurdilo December 14, 2022 13:13

tsurdilo approved these changes Jan 28, 2023

View reviewed changes

tsurdilo merged commit 83e1c21 into serverlessworkflow:main Jan 28, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Enhancement. Reactive api rest for get SVG #216 #217

Enhancement. Reactive api rest for get SVG #216 #217

Uh oh!

Conversation

davideduma commented Dec 2, 2022

Uh oh!

tsurdilo commented Dec 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsurdilo Dec 4, 2022

Choose a reason for hiding this comment

Uh oh!

davideduma Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

tsurdilo commented Dec 4, 2022

Uh oh!

davideduma commented Dec 5, 2022

Uh oh!

davideduma commented Dec 9, 2022

Uh oh!

tsurdilo commented Dec 9, 2022

Uh oh!

sonatype-lift bot Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

davideduma Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

davideduma Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

davideduma Dec 9, 2022

Choose a reason for hiding this comment

Uh oh!

davideduma commented Dec 9, 2022

Uh oh!

davideduma commented Dec 12, 2022

Uh oh!

davideduma commented Dec 26, 2022

Uh oh!

davideduma commented Dec 26, 2022

Uh oh!

Uh oh!

tsurdilo commented Dec 4, 2022 •

edited

Loading