Skip to content

Conversation

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Jan 19, 2022

sajagi and others added 9 commits April 8, 2022 16:59
This new overload is taking an explicit collection of configuration assemblies.
Add an overload of the `Configuration` method that explicitly accepts configuration assemblies
The `serilog-settings-configuration.sln.DotSettings` file defines many custom inspection severities as error rendering the solution with many red squiggly lines when opened in Rider or in Visual Studio with ReSharper.
Fix ReSharper/Rider inspection warnings
@nblumhardt nblumhardt marked this pull request as draft May 11, 2022 23:32
0xced and others added 4 commits May 12, 2022 08:09
* Add .NET 6 target framework instead
* Update tests and sample dependencies
* Simplify conditional package references in all projects
* Remove the custom `PRIVATE_BIN` define, use the built-in `NETFRAMEWORK` instead
* Also use the Visual Studio 2022 image on AppVeyor because VS 2022 is required for the .NET 6 SDK
* Add a reference to `Microsoft.TestPlatform.ObjectModel` so that `dotnet test` also works on Linux and macOS for the .NET Framework targets
* Depend on Microsoft.Extensions.Configuration.Binder: there's no need to depend on Microsoft.Extensions.Options.ConfigurationExtensions, taking a dependency on Microsoft.Extensions.Configuration.Binder is enough for what Serilog.Settings.Configuration needs to do.
Fix some warnings and suggestions proposed by ReSharper
Remove out of support target frameworks
@nblumhardt nblumhardt mentioned this pull request Sep 2, 2022
@nblumhardt nblumhardt marked this pull request as ready for review September 2, 2022 20:54
@nblumhardt nblumhardt changed the title 3.3.1 Release 3.4.0 Release Sep 2, 2022
@nblumhardt
Copy link
Member Author

Bumping minor version, we've added a ReadFrom.Configuration() overload.

@nblumhardt
Copy link
Member Author

I think this is ready to go

@nblumhardt nblumhardt merged commit 06c508d into main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants