Skip to content

Added support for TryReadAsync() with CancellationToken #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

Added support for TryReadAsync() with CancellationToken #44

merged 2 commits into from
Aug 5, 2024

Conversation

Blaisor
Copy link
Contributor

@Blaisor Blaisor commented Aug 4, 2024

From .NET 7, a new ReadLineAsync method has been available, which has a CancellationToken as a parameter. This PR was created to support this newer overload.

nblumhardt
nblumhardt reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this, just a super minor comment, otherwise LGTM 👍

@nblumhardt nblumhardt merged commit b73decb into serilog:dev Aug 5, 2024
@nblumhardt
Copy link
Member

Thanks! 👍

@Blaisor Blaisor deleted the async branch August 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blaisor @nblumhardt