Fix deadlock when calling Dispose from the UI thread. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! |
Merged
Contributor
|
@diegofrata try 2.1.3 |
Contributor
Author
|
Thanks a lot. Will update on Monday!
…On Sat, 4 Mar 2017 at 02:01, Matthew Erbs ***@***.***> wrote:
@diegofrata <https://github.com/diegofrata> try 2.1.3
<https://www.nuget.org/packages/Serilog.Sinks.Splunk/2.1.3>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASwT_mU11MkhDvCNyAzdzM9ku6VBNywks5riMYKgaJpZM4MSJ0D>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if you call Dsipose from the UI thread, or any other thread that has a synchronization context, it blocks and waits for the Send to complete. But then _httpClient.SendAsync tries to complete in the original context, but it can't because it's already blocked. Since there's no timeout, it gets deadlocked forever.
Adding the ConfigureAwait(false) causes the _httpClient request to be completed in the thread pool instead, avoiding the deadlock.