-
Notifications
You must be signed in to change notification settings - Fork 286
Add automated release process and fix tslint errors #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated release process and fix tslint errors #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for implementing this <3
One thing need to be reverted: Can you bring back the package-lock file? If we don't want to publish the lock file to the npm registry, there is a better way to do so: Add the package-lock.json to the .npmignore
file.
The package-lock is still necessary for development and should still be part of this project. I recommend to read the docs: https://docs.npmjs.com/cli/v6/configuring-npm/package-lock-json. :)
I totally forgot to answer your questions.
I did not add anyone as collaborator yet and I also didn't make any efforts to implement an automated release process. Are you interested in being added as a collaborator for this project? |
@RobinBuschmann Right, I bring back the |
@divlo Thanks for fixing ;) |
@RobinBuschmann Good, I answer and closed incorrect issues. If I accidentally closed a real issue, please reopen it. |
Great! Unfortunately I don't have time to check all issues you've commented. So I trust you to be conscientious :) |
Hey @RobinBuschmann, hopefully everything is fine for you! ❤️
Just wanted to know, what is the current state for adding colaborators to the project and how is going with the automated release process via GitHub as discussed in #856.
If you need some help to maintain
sequelize-typescript
, I would be happy to do so. 😃What changes this PR introduce ?
package-lock.json
file since packages on npm doesn't have lockfiles (I added a rule for that in.npmrc)
..github/dependabot.yml
ts-lint
errors since the current build onmaster
is failing.travis.yml
file and instead use GitHub Actions as it is better integrated with GitHub and they change their pricing model, see: blog post.github/workflows/npm-publish.yml)
You will need to set a new secret
NPM_TOKEN
on the repo so it could works as it is explained there.