Sequelize v6 compatibility?

[spinlud]

Is sequelize v6 compatibility still in beta? Any ETA?

[goalia]

+1

[QuanticPotatoes]

+1

[dgomez-orangeloops]

+1

[thetminko]

+1

[goalia]

Apparently @next allow sequelize v6 compatibility #787
Any update @RobinBuschmann ? 🙏🏼

[theoludwig]

Most likely this pull request added support for v6 compatibility #807.
What need to be done, to fully release [email protected] (as a stable release) ? @RobinBuschmann
Maybe we can help, to get this thing done! 🚀

[lukashroch]

#807 should be compatible with v6 up to v6.1 only.

v6.2 introduced some breaking changes to types mostly. You can try #856 for latest (v6.3.5) support

[goalia]

We tried to work with sequelize-typescript@next (2.0-beta) with Nest-Js, it works with sequelize v6.1. @RobinBuschmann we can help you to release v6.3.5 compatibility @lukashroch @divlo 🤷🏼‍♂️

[theoludwig]

As discussed in #871.
I installed [email protected] in my project and I've got many TypeScript errors...
It seems like it stills doesn't work.

[goalia]

Can you show us the « Invitation » model ?
I think it’s because you extends Model in your file like extends Model

[lukashroch]

Looks like you're using old v5 class declaration. You must update all models to reflect v6 changes.

[theoludwig]

Yes, am I doing something wrong ? @goalia

[lukashroch]

@divlo, check out #865, it describes the changes for model declarations

[theoludwig]

Thanks @lukashroch! It solves the problem. 👍

[spinlud]

I was testing the latest beta 2.0.0-beta.1, the following works with just sequelize v6.3.5:

import { Sequelize, Optional, Model, DataTypes } from 'sequelize';

interface PersonAttributes {
    id: number;
    name: string;
    country?: string;
}

interface PersonCreationAttributes extends Optional<PersonAttributes, 'country'> {}

class Person extends Model<PersonAttributes, PersonCreationAttributes> implements PersonAttributes {
    id!: number;
    name!: string;
    country?: string;
}


(async () => {
    const sequelize =  new Sequelize({
        dialect: 'mysql',
        host: 'localhost',
        port: 3306,
        database: 'testdb',
        username: 'admin',
        password: 'admin',
        logQueryParameters: true,
        logging: true,
    });

    await sequelize.authenticate();

    Person.init({
        id: {
            type: DataTypes.INTEGER,
            primaryKey: true,
        },
        name: {
            type: DataTypes.STRING,
            allowNull: false
        },
        country: {
            type: DataTypes.STRING,
            allowNull: true
        }
    }, {
        tableName: 'Person',
        sequelize
    });

    await sequelize.sync();

    const p = new Person({
        id: 1,
        name: 'Ken'
    });

    await p.save();

    const persons = await Person.findAll();
    console.log(persons);

    await sequelize.close();
})();

The following does not work, using sequelize-typscript:

import { Optional } from 'sequelize';
import { Sequelize, Model } from "sequelize-typescript";

interface PersonAttributes {
    id: number;
    name: string;
    country?: string;
}

interface PersonCreationAttributes extends Optional<PersonAttributes, 'country'> {}

class Person extends Model<PersonAttributes, PersonCreationAttributes> implements PersonAttributes {
    id!: number;
    name!: string;
    country?: string;
}


(async () => {
    const sequelize =  new Sequelize({
        dialect: 'mysql',
        host: 'localhost',
        port: 3306,
        database: 'testdb',
        username: 'admin',
        password: 'admin',
        logQueryParameters: true,
        logging: true,
    });

    await sequelize.authenticate();
    
    await sequelize.addModels([Person]); // <-- compiler complains

    await sequelize.sync();

    const p = new Person({
        id: 1,
        name: 'Ken'
    });

    await p.save();

    const persons = await Person.findAll();
    console.log(persons);

    await sequelize.close();
})();

Am I missing something?

[goalia]

Hello @spinlud, you need to replace the following:
class Person extends Model<PersonAttributes, PersonCreationAttributes> implements PersonAttributes
by class Person extends Model implements PersonAttributes
Normally, it should work properly 🎉 (checkout #865 for more details)

[spinlud]

@goalia thanks but this solution doesn't provide type checking on model creation, which I guess is the main reason to extends Model<ModelAttributes, ModelCreationAttributes> signature. Is there any ongoing work on this?

[antonstjernquist]

@spinlud sequelize/sequelize#11820

This PR was created a long time ago. I'm not sure what to do :/

[spinlud]

@antonstjernquist it looks like that that PR was left unmerged, this one has been merged instead sequelize/sequelize#12405.

There is this other PR #868 which seems trying to fix issue about Model generics signature

[theoludwig]

[email protected] has been released! 😄
If you encounter bugs, feel free to open new issues!