Skip to content

Conversation

@semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Jul 22, 2025

PyGPSClient Pull Request Template

Description

FIXES:

  1. Clarify interpretation of SPARTN decryption basedate integer values in *.json configuration file; -1 signifies 'use current datetime' (basedate=None); 0 signifies 'use gnssTimeTag from incoming SPARTN data stream' (basedate=pyspartn.TIMEBASE); any other integer value represents an explicit gnssTimeTag value.
  2. Fix minor bugs in GPX Viewer custom map handling.

ENHANCEMENTS:

  1. Make all Toplevel dialogs scrollable and resizeable, depending on effective screen resolution. Applies to: UBX Config, NMEA Config, NTRIP Client, SPARTN Client, Display GPX Track, Import Custom Map, TTY Commands. This allows the dialogs to be usable on low resolution screens (800 <= width <= 1024 pixels). Feature Request Problems on display with low resolution #204.
  2. Make SPARTN L-Band configuration panel optional via lband_enabled_b configuration setting (disabled by default - ublox PointPerfect SPARTN L-Band service was discontinued in May 2025, though the panel can still be used for other generic L-Band modem configuration purposes). Panel can be re-enabled by setting lband_enabled_b to 1.
  3. Make cryptography library dependency optional (it is only required to decrypt encrypted MQTT SPARTN payloads). If the cryptography library is not installed, the "Decode SPARTN in console" option will be greyed out in the SPARTN MQTT Client dialog.
  4. Allow datalogging and track recording to be enabled or disabled while connected (previously only available while disconnected).
  5. Update minimum pyubx2, pysbf2 and pygnssutils versions to take onboard latest fixes and enhancements.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Test A
  • Test B

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain test coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added this to the RC 1.5.11 milestone Jul 22, 2025
@semuadmin semuadmin requested a review from a team July 22, 2025 08:48
@semuadmin semuadmin self-assigned this Jul 22, 2025
@semuadmin semuadmin added the enhancement New feature or request label Jul 22, 2025
@semuadmin semuadmin marked this pull request as draft July 22, 2025 08:48
@semuadmin semuadmin added the bug Something isn't working label Jul 22, 2025
@semuadmin semuadmin marked this pull request as ready for review August 11, 2025 07:29
@semuadmin semuadmin merged commit 9929038 into master Aug 11, 2025
@semuadmin semuadmin deleted the RC-1.5.11 branch August 11, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants