Skip to content

Update code for extracting "capabilities" from the driver #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdmintz merged 3 commits into from
Jan 16, 2022
Merged

Update code for extracting "capabilities" from the driver #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b011c2
Update code for extracting "capabilities" from the driver
mdmintz Jan 16, 2022
2722ba6
Version 2.3.14
mdmintz Jan 16, 2022
485ecb8
Update a link in the docs
mdmintz Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion help_docs/ReadMe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<a href="https://seleniumbase.io/help_docs/translations/">🌏 Translate</a> |
<a href="https://seleniumbase.io/examples/dialog_boxes/ReadMe/">🛂 DialogBoxes</a>
<br />
<a href="https://seleniumbase.io/help_docs/recorder_mode.md">🔴 Recorder</a> |
<a href="https://seleniumbase.io/help_docs/recorder_mode/">🔴 Recorder</a> |
<a href="https://github.com/seleniumbase/SeleniumBase/tree/master/integrations/node_js">🏃 NodeRunner</a>
<br />
<a href="https://seleniumbase.io/examples/presenter/ReadMe/">🎞️ Presenter</a> |
Expand Down
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "2.3.13"
__version__ = "2.3.14"
11 changes: 8 additions & 3 deletions seleniumbase/fixtures/base_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,13 +1858,13 @@ def hover_on_element(self, selector, by=By.CSS_SELECTOR):
try:
return page_actions.hover_on_element(self.driver, selector)
except WebDriverException as e:
driver_capabilities = self.driver.__dict__["capabilities"]
driver_capabilities = self.driver.capabilities
if "version" in driver_capabilities:
chrome_version = driver_capabilities["version"]
else:
chrome_version = driver_capabilities["browserVersion"]
major_chrome_version = chrome_version.split(".")[0]
chrome_dict = self.driver.__dict__["capabilities"]["chrome"]
chrome_dict = self.driver.capabilities["chrome"]
chromedriver_version = chrome_dict["chromedriverVersion"]
chromedriver_version = chromedriver_version.split(" ")[0]
major_chromedriver_version = chromedriver_version.split(".")[0]
Expand Down Expand Up @@ -10396,7 +10396,12 @@ def __get_major_browser_version(self):
try:
version = self.driver.__dict__["caps"]["browserVersion"]
except Exception:
version = self.driver.__dict__["caps"]["version"]
try:
version = self.driver.__dict__["caps"]["version"]
except Exception:
version = str(
self.driver.__dict__["capabilities"]["version"]
)
self.driver.__dict__["caps"]["browserVersion"] = version
major_browser_version = version.split(".")[0]
return major_browser_version
Expand Down