Remove reference to browsreUnbundlingPublic #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I checked with my other teammates on the Integrations Pillar and DSJ. it seems
browserUnbundlingPubliconly is supposed to impact the app UI and no any routing logic so should not be used to determine connection modes for destinations. In partner portal the settingbrowserUnbundlingPublicdescription states " “Ability to make client side integration beta.” This has caused some destinations to be reporting incorrect destination connection modes, specifically Web<>Cloud mode connections that are not in fact supported.It seems that connection mode for Web<>Cloud should be contingent on
browserUnbundlingSupportedas that is the setting in PP that impacts routing logic.Here is an Example of DoubleClick Floodlight which is seeing the issue:
Related issues (optional)
Original Issues raised: #445
Fix 12/11/19: #447
Breaking Fix 1/21/20: #538