Skip to content

Remove beta tags frontmatter and and autopopulate partner owned for sources #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

tcgilbert
Copy link
Contributor

@tcgilbert tcgilbert commented Aug 7, 2024

Proposed changes

This PR does a few things:

  1. Removes outdated use of beta: true frontmatter
  2. Removes hard coded values for beta status of sources
  3. Makes use of new PAPI functionality that now returns status and partnerOwned for sources

How Beta tags are currently displayed on the site:

  • For destinations, we use the .status field which is returned from PAPI, and loaded into the _data/catalog/destinations.yml file, and are presented like so:

Destination Catalog Pages:

Screenshot 2024-08-07 at 9 24 32 PM

And Destination specific

With the above in mind, considering there is no use for the beta: true frontmatter for destinations, this PR removes it from all the destinations that have this set.

For sources,

there is no .status field returned from PAPI. That being the case, we render the beta tag on the Sources Catalog page, based on manually added ids to a file

Sources Catalog Page: https://segment.com/docs/connections/sources/catalog/

New Beta Tag rendering for sources

With the above in mind, this PR deletes the hardcoded values for source beta status, and updates the updateSources.js file to load status and partnerOwned values for sources into the _data/catalog/sources.yml file.

Previous Source Heading:

  • No beta indication, no partner owned indication
    Screenshot 2024-08-07 at 10 08 47 PM

New Source Heading:

  • adds beta tag, and partner owned
    Screenshot 2024-08-07 at 10 08 38 PM

Open to changing the styling, but just want a consistent way of showing beta status and partner owned for sources

Merge timing

asap

@tcgilbert tcgilbert marked this pull request as ready for review August 8, 2024 02:20
@tcgilbert tcgilbert requested a review from a team as a code owner August 8, 2024 02:20
@tcgilbert tcgilbert requested a review from pwseg August 8, 2024 02:20
@pwseg
Copy link
Contributor

pwseg commented Aug 13, 2024

@tcgilbert This is insane. Really appreciate you.

@pwseg pwseg added the back-end fixes or updates to the site itself, which should not go in release notes label Aug 13, 2024
@pwseg pwseg merged commit b8eb32b into develop Aug 13, 2024
4 checks passed
@pwseg pwseg deleted the thomas/betatags-partnerowned branch August 13, 2024 17:51
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end fixes or updates to the site itself, which should not go in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants