feat(): Introduce side Github links

[imklau]

Related issues (optional)

Closes: #519

[imklau]

Just to be sure,
the hide-feedback field should be responsible for hiding both: feedback buttons and Github links?

and what about the copy in the right nav: should be "Was this page helpful?" or "Is this page helpful?"
I think it doesn't look really great with "Was" because there's too much text that doesn't fit in the one line.

@sanscontext

[sanscontext]

@noeemi Hm, I think for now we can make hide-feedback turn off both, since that'll mostly be used in landing pages now that the Legal docs are out of the repo. (I can probably figure out how to separate them later if needed.)

For the text: "Was this helpful" is more grammatically correct in English, but I agree that it's weird that it spills over into a new line. Is there a different way to solve this without changing "was"?

[imklau]

Hm, I think for now we can make hide-feedback turn off both, since that'll mostly be used in landing pages now that the Legal docs are out of the repo. (I can probably figure out how to separate them later if needed.)

okay, sounds good to me!

For the text: "Was this helpful" is more grammatically correct in English, but I agree that it's weird that it spills over into a new line. Is there a different way to solve this without changing "was"?

The design contains "Is this page helpful?" too and I thought maybe I made the mistake but now I see :)

Our sidebar:

has 144px width so the best way to solve this would be to increase the size to 150px. It's just 6px more but in this case, it's enough. (and it's a really quick fix :D)

[netlify]

Deploy preview for segment-docs-preview ready!

Built with commit a524c51

https://deploy-preview-676--segment-docs-preview.netlify.app

[markzegarelli]

closing. This was brought up to date in #1584