Add updates from prev pull request for Ripe #6628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
src/connections/destinations/catalog/actions-ripe-cloud/index.md
Outdated
Show resolved
Hide resolved
src/connections/destinations/catalog/actions-ripe-cloud/index.md
Outdated
Show resolved
Hide resolved
forstisabella
added
the
content-update
Co-authored-by: forstisabella <[email protected]>
cmastr
reviewed
May 31, 2024
|
|
||
| ### Identify | ||
|
|
||
| Take a look at the [Page method documentation](/docs/connections/spec/page/) to learn about what it does. An example call would look like this: |
There was a problem hiding this comment.
Why are we pointing to page method here instead of identify method?
src/connections/destinations/catalog/actions-ripe-cloud/index.md
Outdated
Show resolved
Hide resolved
| If you aren't familiar with the Segment Spec, take a look at | ||
| the [Identify method documentation](/docs/connections/spec/identify/) to learn | ||
| about what it does. An example call would look like: | ||
| Take a look at the [Page method documentation](/docs/connections/spec/page/) to learn about what it does. An example call would look like this: |
There was a problem hiding this comment.
Is page method the right place to point instead of Identify?
Co-authored-by: Casie Oxford <[email protected]>
cmastr
approved these changes
Jun 6, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Taking the updates from this PR without the name changes
Merge timing
asap