Skip to content

schematic documentation #6525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 14, 2024
Merged

schematic documentation #6525

merged 10 commits into from
May 14, 2024

Conversation

jasdeepg
Copy link
Contributor

@jasdeepg jasdeepg commented May 9, 2024 •
edited
Loading

Proposed changes

Added Schematic docs based on template.

Merge timing

ASAP once approved

@jasdeepg jasdeepg requested a review from a team as a code owner May 9, 2024 22:40
@jasdeepg jasdeepg requested review from forstisabella and removed request for a team May 9, 2024 22:40
@forstisabella forstisabella added the new-integration Added a new source or destination label May 10, 2024
@forstisabella forstisabella requested a review from tcgilbert May 10, 2024 17:06
@forstisabella
Copy link
Contributor

hi @jasdeepg - please revert changes to the package-lock.json-lock and yarn.lock files.

forstisabella
forstisabella reviewed May 10, 2024
View reviewed changes
src/connections/destinations/catalog/schematic/index.md Outdated
Copy link
Contributor

@forstisabella forstisabella May 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jasdeepg - please update the file folder to match the slug that this integration has in the Segment app: actions-schematic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did both - thanks!

@forstisabella forstisabella self-requested a review May 10, 2024 19:50
forstisabella
forstisabella requested changes May 10, 2024
View reviewed changes
tcgilbert
tcgilbert suggested changes May 13, 2024
View reviewed changes
@jasdeepg
Copy link
Contributor Author

hi - i believe all changes are in, but let me know if i missed anything.

@forstisabella forstisabella merged commit 86676ea into segmentio:develop May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@tcgilbert
Copy link
Contributor

@jasdeepg

I have gone ahead and made your integration live. Twilio Segment is excited to move your new integration into the Public Catalog!

To move out of beta, you can write back into [email protected] once you have at least one customer using the integration, and you are confident that the beta status is no longer applicable.

If you have any questions or concerns, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstisabella forstisabella forstisabella approved these changes

+1 more reviewer

@tcgilbert tcgilbert tcgilbert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
new-integration Added a new source or destination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasdeepg @forstisabella @tcgilbert