add methods to destinations.yml #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to add booleans for whether each method is supported by each destination. I've put this code together, and when I try to run in on my local setup, it's not updating the destinations.yml file and I'm not sure why.
Contributor
|
Hey @AaronAtSegment are these fields exposed in the ConfigAPI currently? 🤔 |
Contributor
Author
|
after a lot of help from Laura, I used the make catalog command and I simplified the code and it worked! |
Contributor
Author
|
Contributor
|
I am unqualified to comment too deeply on JS files. @XavierAgostini and or @danielstjules can I get a 👀 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add booleans for whether each method is supported by each destination. I've put this code together, and when I try to run in on my local setup, it's not updating the destinations.yml file and I'm not sure why.
Proposed changes
I want to add to the xyyzy page information about whether a destination supports personas and list which methods are supported
Related issues (optional)