Adding a note to xid docs #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanscontext
approved these changes
Jan 22, 2020
Contributor
sanscontext
left a comment
sanscontext
left a comment
There was a problem hiding this comment.
One formatting suggestion, otherwise approved. Thanks for taking a look here!
gh-osama
approved these changes
Jan 23, 2020
Contributor
gh-osama
left a comment
gh-osama
left a comment
There was a problem hiding this comment.
lgtm with the slight change by @sanscontext!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Since we're no longer supporting cross-domain analytics for new customers, I'm adding a note letting prospects that's the case. However, we still want to keep the docs live for the hundred or so existing customers that are currently using cross-domain analytics until it has been turned off for them.