Add device mode note to Protocols transformations #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanscontext
reviewed
Jan 7, 2020
| Transformations _irrevocably_ change the event payloads flowing through Segment and immediately affect either all destinations, or a single downstream destination, depending on your settings. | ||
|
|
||
| > **Warning**: Once you apply Transformations, the original tracking payloads are not easily recoverable. | ||
| > warning "" |
Contributor
There was a problem hiding this comment.
This one might be worth using the error format, since it could be considered data-destructive.
sanscontext
approved these changes
Jan 7, 2020
Contributor
sanscontext
left a comment
sanscontext
left a comment
There was a problem hiding this comment.
One nit, but not stop ship. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Why:
It's a common assumption among customers and the current warnings lower in the doc are not clear enough.