-
Notifications
You must be signed in to change notification settings - Fork 395
Fixes from docs dashboard set 1 #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| The following images show an example of mapping "Gender" to dimension "1" and "User Type" to dimension "2": | ||
|
|
||
| On Segment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdaswani I removed the images as they currently aren't showing up on the docs site, and when i took a look at the images, I didn't think they added much value to the page nor did they seem that helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me to remove images! thanks @stayseesong !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I am able to see the images on the docs site though here: https://segment.com/docs/connections/destinations/catalog/google-analytics/#setting-up-custom-dimensions. but anything works for me if you need to remove!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok! I realized I wasn't able to see the images because one of my chrome extensions was blocking it
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Merge timing
Related issues (optional)