Skip to content

Conversation

@stayseesong
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@stayseesong stayseesong requested a review from kdaswani as a code owner July 29, 2022 23:10
@stayseesong stayseesong requested review from kdaswani and removed request for kdaswani July 29, 2022 23:10

The following images show an example of mapping "Gender" to dimension "1" and "User Type" to dimension "2":

On Segment:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdaswani I removed the images as they currently aren't showing up on the docs site, and when i took a look at the images, I didn't think they added much value to the page nor did they seem that helpful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me to remove images! thanks @stayseesong !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I am able to see the images on the docs site though here: https://segment.com/docs/connections/destinations/catalog/google-analytics/#setting-up-custom-dimensions. but anything works for me if you need to remove!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! I realized I wasn't able to see the images because one of my chrome extensions was blocking it

@markzegarelli markzegarelli self-requested a review August 1, 2022 22:41
@stayseesong stayseesong marked this pull request as draft August 1, 2022 22:43
@stayseesong stayseesong marked this pull request as ready for review August 4, 2022 23:11
@stayseesong stayseesong requested a review from a team as a code owner August 4, 2022 23:11
@stayseesong stayseesong changed the title Fixes from docs dashboard Fixes from docs dashboard set 1 Aug 4, 2022
@stayseesong stayseesong added content-update updates to content that are not new features, includes grammar fixes, added notes fixed-content fix to content that has outdated or wrong information and removed content-update updates to content that are not new features, includes grammar fixes, added notes labels Aug 9, 2022
@stayseesong stayseesong merged commit 5970648 into develop Aug 9, 2022
@stayseesong stayseesong deleted the fixes-from-docs-dashboard-1 branch August 9, 2022 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed-content fix to content that has outdated or wrong information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants