Update Mixpanel Group device-mode documentation #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Group device-mode call information to call out that userId must be set or no group call will be sent to Mixpanel when using AJS
added 2 commits
October 15, 2021 15:39
|
👋 Hello. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: Please revert all files in this list and resubmit your pull request. |
markzegarelli
approved these changes
Oct 15, 2021
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Group device-mode call information to call out that userId must be set or no group call will be sent to Mixpanel when using AJS
Proposed changes
Added additional information regarding Group calls in device-mode when using AJS. Specifically to address that userId must be set in order for our integration to send group calls.
https://github.com/segmentio/analytics.js-integrations/blob/9d2ab0a2c24cf5ed9f5d4ac103c4428a3772d727/integrations/mixpanel/lib/index.js#L335
Group calls are silently dropped.
Merge timing
ASAP
Related issues (optional)
n/a