Skip to content

Update FB Pixel and Conversions API docs #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2021
Merged

Update FB Pixel and Conversions API docs #1996

merged 5 commits into from
Oct 11, 2021

Conversation

kdaswani
Copy link
Contributor

Proposed changes

  • Update FB Pixel docs to explain requirements for using external_id
  • Update FB Conversions API docs to explain requirements for using external_id client-side

Merge timing

  • ASAP once approved

Related issues

https://segment.atlassian.net/browse/STRATCONN-968

@kdaswani kdaswani requested a review from a team as a code owner October 11, 2021 20:15
@kdaswani kdaswani requested review from stayseesong and removed request for a team October 11, 2021 20:15
@kdaswani
Copy link
Contributor Author

Adding docs changes to FB Conversions API to this PR right now.

@kdaswani
Copy link
Contributor Author

hi @markzegarelli! we needed to update a few settings as part of these updates, so can you please run make catalog and add to this PR?

also, I noticed the branch chosen to merge into is develop instead of master. is that expected? thanks!

@markzegarelli
Copy link
Contributor

also, I noticed the branch chosen to merge into is develop instead of master. is that expected? thanks!

Hey @kdaswani, yes this is expected. We have transitioned to having twice-weekly docs releases. We do this by queuing work in develop and then merging to master at set times throughout the week.

@markzegarelli markzegarelli removed the request for review from stayseesong October 11, 2021 21:42
@markzegarelli markzegarelli added content When the bug is about content that needs to get fixed enhancement labels Oct 11, 2021
@markzegarelli markzegarelli merged commit 490ddf0 into develop Oct 11, 2021
@markzegarelli markzegarelli deleted the update-fb-docs branch October 11, 2021 22:22
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

kdaswani
kdaswani commented Oct 11, 2021
View reviewed changes
src/connections/destinations/catalog/facebook-pixel-server-side/index.md
@@ -123,7 +123,7 @@ For more information about Track calls, see the [Track method](/docs/connections

Beginning February 15th 2021, Facebook requires the `action_source` server event parameter for all events sent to the Conversions API. This parameter is used to specify where the conversions occurred. If `action_source` is set to 'website' then the `client_user_agent` and the `event_source_url` parameters are also required. Events sent to the Conversions API after February 15th that do not meet the requirements may not be available for optimization, targeting, or measurement.

| Server Event Parameter | Requirement | Implementation |
| Server Event Parameter | Requirement | Implementation p |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markzegarelli was adding this p intentional?

This was referenced Nov 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James9446 James9446 Awaiting requested review from James9446

1 more reviewer

@markzegarelli markzegarelli markzegarelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
content When the bug is about content that needs to get fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdaswani @markzegarelli