Skip to content

Fixed search keyboard navigation #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fixed search keyboard navigation #1970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions js/algolia/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const placeHolder = envApiKey != null ? 'Search the Segment documentation' : 'Se
const searchClient = algoliasearch(appId, apiKey);

//insights
insightsClient('init', { appId, apiKey });
insightsClient('init', { appId, apiKey, useCookie: true });
const algoliaInsightsPlugin = createAlgoliaInsightsPlugin({ insightsClient });

// define locations to separate invocation for mobile and desktop
Expand All @@ -39,9 +39,9 @@ function initAutocomplete(item){
sourceId: 'articles',
getItemUrl({ item }){
if (item.anchor != null) {
var itemUrl = item.url+"#" + item.anchor;
var itemUrl = '/docs'+item.url+"#" + item.anchor;
} else {
var itemUrl = item.url;
var itemUrl = '/docs'+item.url;
}
return itemUrl;
},
Expand Down Expand Up @@ -87,9 +87,19 @@ function initAutocomplete(item){
},
navigator: {
navigate({ itemUrl }) {
window.location.assign('/docs'+itemUrl);
window.location.assign(itemUrl);
},
}
navigateNewTab({ itemUrl }) {
const windowReference = window.open(itemUrl, '_blank', 'noopener');

if (windowReference) {
windowReference.focus();
}
},
navigateNewWindow({ itemUrl }) {
window.open(itemUrl, '_blank', 'noopener');
},
},
});

}
Expand Down