DOC-332 added overrides for Friendbuy #1969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwseg
approved these changes
Oct 6, 2021
| type: mixed | ||
| defaultValue: [] | ||
| description: >- | ||
| By default, Friendbuy recommends you add a site wide overlay widget. You |
There was a problem hiding this comment.
Suggested change
| By default, Friendbuy recommends you add a site wide overlay widget. You | |
| By default, Friendbuy recommends that you add a site wide overlay widget. You |
This is minor, but I'd explicitly write out the relative pronoun here. It helps with users who put our pages through online translators.
| @@ -37,9 +34,10 @@ There are two types of Widgets you can map to your Page calls: | |||
| - Other widgets | |||
| - All other widgets will fall under this category whereby you can map the `name` of a unique Segment `.page()` call to a widget ID. | |||
|
|
|||
| _NOTE_: If you have mapped a site wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. | |||
| > info "" | |||
| > If you have mapped a site wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. | |||
There was a problem hiding this comment.
Something seems to be missing from this sentence. Should it say ".... overlay widget that loads..."? or "...overlay, then the widget loads"....?
| @@ -37,9 +34,10 @@ There are two types of Widgets you can map to your Page calls: | |||
| - Other widgets | |||
| - All other widgets will fall under this category whereby you can map the `name` of a unique Segment `.page()` call to a widget ID. | |||
|
|
|||
| _NOTE_: If you have mapped a site wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. | |||
| > info "" | |||
| > If you have mapped a site wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. | |||
There was a problem hiding this comment.
Suggested change
| > If you have mapped a site wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. | |
| > If you have mapped a site-wide overlay widget loads on every `.page()` call, even if we have loaded a different widget on the page that you have explicitly mapped. |
| can enter any of these site wide widgets here and we will load them any | ||
| time we receive a `.page()` call. *Note*: If you have custom widgets | ||
| mapped to named pages in the *Widgets* setting and you have provided a | ||
| site wide widget, we will load both. |
There was a problem hiding this comment.
I think when it's used as an adjective, site-wide requires a hyphen.
markzegarelli
added
the
fixed-content
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added an override for Friendbuy as a result of DOC-332.
Merge timing
Standard