Skip to content

Adding kochava links #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Adding kochava links #1941

merged 3 commits into from
Oct 1, 2021

Conversation

gezgblack
Copy link
Contributor

Proposed changes

In this PR I have added links to Kochava in our docs. This change has been made upon their request in this ticket https://segment.zendesk.com/agent/tickets/441026. Let me know if you're against adding these links and you want me to push back on them.

Merge timing

No urgent. Feel free to merge once approved.

@gezgblack gezgblack requested a review from a team as a code owner October 1, 2021 11:08
@markzegarelli markzegarelli changed the base branch from master to develop October 1, 2021 17:32
@markzegarelli
Copy link
Contributor

Thanks @gezgblack. I don't have an issue with including links. I will tweak the language a little bit and also add a link to Tune where applicable, so we do not appear to favor one over the other.

Base automatically changed from develop to master October 1, 2021 23:26
@markzegarelli markzegarelli changed the base branch from master to develop October 1, 2021 23:28
@markzegarelli markzegarelli merged commit bbaf5f4 into develop Oct 1, 2021
@markzegarelli markzegarelli deleted the kochavaLinks branch October 1, 2021 23:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants