Added support for SASL PLAIN and SCRAM mechanisms #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial contribution that provides a skeleton for SASL support. For more information about the authentication sequence, please see https://kafka.apache.org/protocol#sasl_handshake
Also ensured that adding support for new mechanisms in the future is as straightforward as possible.
Closed
achille-roussel
approved these changes
Mar 15, 2019
Contributor
achille-roussel
left a comment
achille-roussel
left a comment
There was a problem hiding this comment.
This looks great 👍 Thanks for taking care of it!
sasl/scram/scram.go
Outdated
|
|
||
| // HashFunction determines the hash function used by SCRAM to protect the user's | ||
| // credentials. | ||
| type HashFunction int |
Contributor
There was a problem hiding this comment.
Any reasons not to make this an interface with implementations for the SHA256 and SHA512 hash functions instead of an enum type?
Contributor
Author
There was a problem hiding this comment.
I did have reasons...the most important of which was to make sure we didn't export anything 3rd party libraries (e.g. in case we swap out scram providers later). But I think that can also be done with an interface. I just pushed up what I would see as the interface version...let me know which you prefer!
This was referenced Mar 18, 2019
sasl/scram/scram.go
Outdated
| // | ||
| // SCRAM-SHA-256 and SCRAM-SHA-512 were added to Kafka in 0.10.2.0. These | ||
| // mechanisms will not work with older versions. | ||
| func Mechanism(algo Algorithm, username, password string) (*mechanism, error) { |
Contributor
There was a problem hiding this comment.
Exposing an unexported type in the return value here is a bit weird, was this intended?
added 2 commits
March 18, 2019 12:04
* moved Mechanism -> sasl.Mechanism * moved common test code -> testing package * return sasl.Mechanism in scram constructor instead of *mechanism
achille-roussel
approved these changes
Mar 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up the work on the inactive PR #134 in order to drive it to conclusion.