Skip to content

migrate typography components to typescript #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 13, 2019
Merged

migrate typography components to typescript #553

merged 9 commits into from
May 13, 2019

Conversation

mshwery
Copy link
Contributor

@mshwery mshwery commented May 11, 2019

This PR migrates all of the components in typography over to proper Props types.

@mshwery mshwery requested a review from solon-aguiar May 11, 2019 19:14
solon-aguiar
solon-aguiar reviewed May 13, 2019
View reviewed changes
Copy link
Contributor

@solon-aguiar solon-aguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions.

src/text-input/src/TextInput.tsx
@@ -48,7 +48,7 @@ class TextInput extends PureComponent<any & React.ComponentProps<typeof Text>> {
theme: PropTypes.object.isRequired,

/**
* Class name passed to the button.
* Class name passed to the input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

solon-aguiar
solon-aguiar approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@solon-aguiar solon-aguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it

@mshwery mshwery merged commit 1ca7a43 into typescript May 13, 2019
@mshwery mshwery deleted the ts/typography branch May 13, 2019 17:54
@mshwery mshwery mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solon-aguiar solon-aguiar solon-aguiar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshwery @solon-aguiar