Skip to content

KLAVIYO - Mapped total key in klaviyo payload #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023
Merged

KLAVIYO - Mapped total key in klaviyo payload #745

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2e8110
added total key
Apr 4, 2023
2df8953
updated klaviyo version
Apr 6, 2023
f346c56
removed total from whitelist
Apr 10, 2023
370afd3
test case if revenue missing
Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion integrations/klaviyo/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ Klaviyo.prototype.orderCompleted = function(track) {
'itemNames',
'items',
'revenue',
'total',
'products'
];
// strip standard props and leave custom props only
Expand Down
2 changes: 1 addition & 1 deletion integrations/klaviyo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-klaviyo",
"description": "The Klaviyo analytics.js integration.",
"version": "2.2.5",
"version": "2.2.6",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
3 changes: 3 additions & 0 deletions integrations/klaviyo/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ describe('Klaviyo', function() {
$value: 25,
Categories: ['Games', 'Interwebs'],
ItemNames: ['Monopoly: 3rd Edition', 'Suh dude'],
total: 30,
Items: [
{
id: '507f1f77bcf86cd799439011',
Expand Down Expand Up @@ -291,6 +292,7 @@ describe('Klaviyo', function() {
$value: 25,
Categories: ['Games'],
ItemNames: ['Monopoly: 3rd Edition'],
total: 30,
Items: [
{
id: '507f1f77bcf86cd799439011',
Expand Down Expand Up @@ -452,6 +454,7 @@ describe('Klaviyo', function() {
$value: 25,
Categories: ['Games', 'Interwebs'],
ItemNames: ['Monopoly: 3rd Edition', 'Suh dude'],
total: 30,
Items: [
{
id: '507f1f77bcf86cd799439011',
Expand Down