Added product Id in Ordered Product track event of klaviyo #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@AnkitUnthinkable - Can we add or update unit test cases to ensure we are sending the productId?
varadarajan-tw
approved these changes
Mar 20, 2023
|
Can you also pls bump the package version here? |
AnkitUnthinkable
deleted the
HGI-394-klaviyo-product-id-is-not-being-mapped-to-product-id-of-the-prodcut
branch
AnkitUnthinkable
restored the
HGI-394-klaviyo-product-id-is-not-being-mapped-to-product-id-of-the-prodcut
branch
AnkitUnthinkable
added a commit
that referenced
this pull request
Mar 30, 2023
* STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
AnkitUnthinkable
added a commit
that referenced
this pull request
Mar 30, 2023
* STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings * Package version change for sentry --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added Product Id parameter in ordered product track event of klaviyo, also changed id to productId in order completed track event of klaviyo
JIRA TICKET: https://segment.atlassian.net/browse/HGI-394?atlOrigin=eyJpIjoiZjRmNDZlZjliYzFlNGMwODk0ZTBjNzgzOGZkMTgxNTAiLCJwIjoiaiJ9
Are there breaking changes in this PR?
NO
Testing completed successfully in localhost