STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooyaj
approved these changes
Feb 7, 2023
AnkitUnthinkable
added a commit
that referenced
this pull request
Mar 30, 2023
* STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
AnkitUnthinkable
added a commit
that referenced
this pull request
Mar 30, 2023
* STRATCONN-1287 - Add support for DoubleClick Floodlight config in in Google Ads (GTag) (#730) * Google Ads (GTag): add support for doubleclick floodlight id * nit: add floodlightAccountId as an option to the initializer * bump package.json for google ads * Added product Id in Ordered Product track event of klaviyo (#736) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added --------- Co-authored-by: Ankit Gupta <[email protected]> * HGI-394 klaviyo package.json Version update (#738) * Added product Id in Ordered Product track event of klaviyo * Klaviyo unit test cases added * Change veriable name productId to ProductID as klaviyo description * HGI-394 Test case added * Klaviyo version update --------- Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * HGI-404 version upgraded of sentry from 5.12.1 to 7.45.0 * HGI-404 change cdn settings * Package version change for sentry --------- Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Varadarajan V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following PR intends to provide a workaround for browsers that are not able to set DC cookies through normal means, so we are leveraging GTag to set those cookies. See ticket STRATCONN-1287 for more information.
Are there breaking changes in this PR?
No, all changes are backwards compatible.
Testing
Testing completed successfully in local tester via checking for regressions, as we are unable to test E2E to see the effect of the changes. Will rely on customer to assist in validation. See ticket for details.
Does this require a new integration setting? If so, please explain how the new setting works
Yes, this requires a new optional setting called
floodlightAccountIdwhich represents the DoubleClick Floodlight Config ID. It will be passed to gtag'sconfigparameter as part of the integration initialization.Links to helpful docs and other external resources
https://segment.atlassian.net/browse/STRATCONN-1287
https://support.google.com/campaignmanager/answer/7554821?hl=en#zippy=%2Cstep-add-the-global-snippet-to-every-page-of-your-site%2Cstep-add-the-event-snippet-to-pages-with-events-youre-tracking