Skip to content

fix: Amplitude session_id fix #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Amplitude session_id fix #1104

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9759e2
feat: fixed session_ID issue
Oct 27, 2025
3d773fe
refactor: removed unused code, comments and console logs
Oct 28, 2025
d5cf5a6
refactor: fixed ESlint issues
Oct 28, 2025
4e3f07b
refactor: refactored to add properties for Event_Session_ID and Last_…
Oct 29, 2025
ff221c5
refactor: removed used code
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 148 additions & 27 deletions packages/plugins/plugin-amplitudeSession/src/AmplitudeSessionPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { AppState } from 'react-native';

const MAX_SESSION_TIME_IN_MS = 300000;
const SESSION_ID_KEY = 'previous_session_id';
const EVENT_SESSION_ID_KEY = 'event_session_id';
const LAST_EVENT_TIME_KEY = 'last_event_time';
const AMP_SESSION_START_EVENT = 'session_start';
const AMP_SESSION_END_EVENT = 'session_end';
Expand All @@ -27,7 +28,40 @@ export class AmplitudeSessionPlugin extends EventPlugin {
key = 'Actions Amplitude';
active = false;
sessionId = -1;
lastEventTime = -1;
private _eventSessionId = -1;
private _lastEventTime = -1;
resetPending = false;

get eventSessionId() {
return this._eventSessionId;
}
set eventSessionId(value: number) {
this._eventSessionId = value;
if (value !== -1) {
AsyncStorage.setItem(EVENT_SESSION_ID_KEY, value.toString()).catch(
(err) =>
console.warn(
'[AmplitudeSessionPlugin] Failed to persist eventSessionId:',
err
)
);
}
}

get lastEventTime() {
return this._lastEventTime;
}
set lastEventTime(value: number) {
this._lastEventTime = value;
if (value !== -1) {
AsyncStorage.setItem(LAST_EVENT_TIME_KEY, value.toString()).catch((err) =>
console.warn(
'[AmplitudeSessionPlugin] Failed to persist lastEventTime:',
err
)
);
}
}

configure = async (analytics: SegmentClient): Promise<void> => {
this.analytics = analytics;
Expand All @@ -50,9 +84,7 @@ export class AmplitudeSessionPlugin extends EventPlugin {
if (this.sessionId === -1 || this.lastEventTime === -1) {
await this.loadSessionData();
}

await this.startNewSessionIfNecessary();

let result = event;
switch (result.type) {
case EventType.IdentifyEvent:
Expand All @@ -73,8 +105,7 @@ export class AmplitudeSessionPlugin extends EventPlugin {
}

this.lastEventTime = Date.now();
await this.saveSessionData();

//await this.saveSessionData();
return result;
}

Expand All @@ -83,6 +114,32 @@ export class AmplitudeSessionPlugin extends EventPlugin {
}

track(event: TrackEventType) {
const eventName = event.event;

if (eventName === AMP_SESSION_START_EVENT) {
this.resetPending = false;
this.eventSessionId = this.sessionId;
}

if (eventName === AMP_SESSION_END_EVENT) {
console.log(`[AmplitudeSession] EndSession = ${this.eventSessionId}`);
}

if (
eventName.startsWith('Amplitude') ||
eventName === AMP_SESSION_START_EVENT ||
eventName === AMP_SESSION_END_EVENT
) {
const integrations = this.disableAllIntegrations(event.integrations);
return {
...event,
integrations: {
...integrations,
[this.key]: { session_id: this.eventSessionId },
},
};
}

return this.insertSession(event) as TrackEventType;
}

Expand All @@ -104,9 +161,13 @@ export class AmplitudeSessionPlugin extends EventPlugin {

async reset() {
this.sessionId = -1;
this.eventSessionId = -1;
this.lastEventTime = -1;
await AsyncStorage.removeItem(SESSION_ID_KEY);
await AsyncStorage.removeItem(LAST_EVENT_TIME_KEY);
await AsyncStorage.multiRemove([
SESSION_ID_KEY,
EVENT_SESSION_ID_KEY,
LAST_EVENT_TIME_KEY,
]);
}

private insertSession = (event: SegmentEvent) => {
Expand All @@ -132,68 +193,128 @@ export class AmplitudeSessionPlugin extends EventPlugin {

private onBackground = () => {
this.lastEventTime = Date.now();
this.saveSessionData();
//this.saveSessionData();
};

private onForeground = () => {
this.startNewSessionIfNecessary();
};

private async startNewSessionIfNecessary() {
if (this.eventSessionId === -1) {
this.eventSessionId = this.sessionId;
}

if (this.resetPending) {
return;
}

const current = Date.now();
const withinSessionLimit = this.withinMinSessionTime(current);

const sessionExpired =
this.sessionId === -1 ||
this.lastEventTime === -1 ||
current - this.lastEventTime >= MAX_SESSION_TIME_IN_MS;
const isSessionExpired =
this.sessionId === -1 || this.lastEventTime === -1 || !withinSessionLimit;

// Avoid loop: if session just started recently, skip restarting
if (!sessionExpired || current - this.sessionId < 1000) {
if (this.sessionId >= 0 && !isSessionExpired) {
return;
}

await this.endSession();
// End old session and start a new one
await this.startNewSession();
}

/**
* Handles the entire process of starting a new session.
* Can be called directly or from startNewSessionIfNecessary()
*/
private async startNewSession() {
this.sessionId = Date.now();
this.lastEventTime = this.sessionId;
await this.saveSessionData();
if (this.resetPending) {
return;
}

this.resetPending = true;

const oldSessionId = this.sessionId;
if (oldSessionId >= 0) {
await this.endSession(oldSessionId);
}

const newSessionId = Date.now();
this.sessionId = newSessionId;
this.eventSessionId =
this.eventSessionId === -1 ? newSessionId : this.eventSessionId;
this.lastEventTime = newSessionId;

//await this.saveSessionData();

console.log(`[AmplitudeSession] startNewSession -> ${newSessionId}`);

await this.trackSessionStart(newSessionId);
}

/**
* Extracted analytics tracking into its own method
*/
private async trackSessionStart(sessionId: number) {
this.analytics?.track(AMP_SESSION_START_EVENT, {
integrations: {
[this.key]: { session_id: this.sessionId },
[this.key]: { session_id: sessionId },
},
});
}

private async endSession() {
private async endSession(sessionId: number) {
if (this.sessionId === -1) {
return;
}

console.log(`[AmplitudeSession] endSession -> ${this.sessionId}`);

this.analytics?.track(AMP_SESSION_END_EVENT, {
integrations: {
[this.key]: { session_id: this.sessionId },
[this.key]: { session_id: sessionId },
},
});
}

private async loadSessionData() {
const storedSessionId = await AsyncStorage.getItem(SESSION_ID_KEY);
const storedLastEventTime = await AsyncStorage.getItem(LAST_EVENT_TIME_KEY);
const storedEventSessionId = await AsyncStorage.getItem(
EVENT_SESSION_ID_KEY
);

this.sessionId = storedSessionId != null ? Number(storedSessionId) : -1;
this.lastEventTime =
storedLastEventTime != null ? Number(storedLastEventTime) : -1;
this.eventSessionId =
storedEventSessionId != null ? Number(storedEventSessionId) : -1;
}

private async saveSessionData() {
await AsyncStorage.setItem(SESSION_ID_KEY, this.sessionId.toString());
await AsyncStorage.setItem(
LAST_EVENT_TIME_KEY,
this.lastEventTime.toString()
);
// private async saveSessionData() {
// await AsyncStorage.setItem(SESSION_ID_KEY, this.sessionId.toString());
// await AsyncStorage.setItem(
// LAST_EVENT_TIME_KEY,
// this.lastEventTime.toString()
// );
// }

// eslint-disable-next-line @typescript-eslint/no-explicit-any
private disableAllIntegrations(integrations?: Record<string, any>) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const result: Record<string, any> = {};
if (!integrations) {
return result;
}
for (const key of Object.keys(integrations)) {
result[key] = false;
}
return result;
}

private withinMinSessionTime(timestamp: number): boolean {
const timeDelta = timestamp - this.lastEventTime;
return timeDelta < MAX_SESSION_TIME_IN_MS;
}

private handleAppStateChange = (nextAppState: string) => {
Expand Down
Loading
Loading