fix: fixed race condition causing events to be lost during initialization #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical race condition that causes events to be lost when they are tracked while the Segment client is processing pending events during initialization.
Problem
Events tracked during the app startup phase were being lost. When the Segment client initializes, it processes any events that were tracked before it was ready (pending events).
However, due to a race condition, new events arriving during this processing period were incorrectly saved as "pending" and never sent.
Reproduction Steps
Track events immediately when a React Native app starts
Track additional events within the first 2-4 seconds
Observe that only a subset of events are sent to Segment
Root Cause
The isReady flag was being set AFTER the onReady() function completed processing pending events. This created a window where:
Pending events are being processed
New events arrive and check isReady.value
Since isReady.value is still false, they get saved as pending
But the pending processor has already run, so these events are never sent
Solution
Set the isReady flag to true BEFORE processing pending events, not after. This ensures any events arriving during initialization go directly to the queue.