Skip to content

Conversation

@sunitaprajapati89
Copy link
Contributor

This PR fixes a critical race condition that causes events to be lost when they are tracked while the Segment client is processing pending events during initialization.

Problem
Events tracked during the app startup phase were being lost. When the Segment client initializes, it processes any events that were tracked before it was ready (pending events).
However, due to a race condition, new events arriving during this processing period were incorrectly saved as "pending" and never sent.

Reproduction Steps
Track events immediately when a React Native app starts
Track additional events within the first 2-4 seconds
Observe that only a subset of events are sent to Segment
Root Cause
The isReady flag was being set AFTER the onReady() function completed processing pending events. This created a window where:

Pending events are being processed
New events arrive and check isReady.value
Since isReady.value is still false, they get saved as pending
But the pending processor has already run, so these events are never sent
Solution
Set the isReady flag to true BEFORE processing pending events, not after. This ensures any events arriving during initialization go directly to the queue.

…tion

- added unit test cases
- fixed the race condition
- refactored onReady()
- removed unused tests which were written for wrong fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants