Wenxi/convenience methods and misses for plugin authors #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
approved these changes
Nov 30, 2021
| return JsonObject(content) | ||
| } | ||
|
|
||
| operator fun MutableMap<String, JsonElement>.set(key:String, value: String?) { |
There was a problem hiding this comment.
would adding these APIs on such a widely used type (like MutableMap) have consequences?
There was a problem hiding this comment.
yeah. that's a valid concern. the good thing is that it only overrides set operator for MutableMap<String, JsonElement>, not the other types. I tried MutableMap<String, String>, it's not impacted. so the impact is limited.
wenxi-zeng
deleted the
wenxi/convenience-methods-and-misses-for-plugin-authors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enableIntegration,disableIntegration,disableCloudIntegrations,enableCloudIntegrationsupdateJsonObjectto JSON wrapper for easier content manipulationmanuallyEnableDestinationis already implemented in pr Integrations Logic fix + Copy mechanism for payloads #59