setup github actions #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into wenxi/setup-github-actions
…ntio/analytics-kotlin into wenxi/setup-github-actions
This reverts commit 5d07077
…ntio/analytics-kotlin into wenxi/setup-github-actions
prayansh
approved these changes
Oct 14, 2021
| every { analytics.networkIODispatcher } returns testDispatcher | ||
| every { analytics.fileIODispatcher } returns testDispatcher | ||
| every { analytics.store } returns spyStore(testScope, testDispatcher) | ||
| lifecyclePlugin = AndroidLifecyclePlugin() |
There was a problem hiding this comment.
any reason why this needs to be initialized here vs how it was before
There was a problem hiding this comment.
yeah. this does not have to be here. I will revert this change. I was blindly trying to fix the flaky test. this eliminated a possible cause, since AndroidLifecyclePlugin manages some states internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.