Skip to content

add new helpers for destinations work #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2021
Merged

add new helpers for destinations work #18

merged 1 commit into from
Aug 3, 2021

Conversation

prayansh
Copy link
Contributor

@prayansh prayansh commented Aug 3, 2021

I am adding a bunch of new functions/apis that will aid in building new destinations.

+ Settings.isDestinationEnabled(name: String)
+ Settings.destinationSettings(name: String) // Will produce a typed config

+ JsonObject.transformKeys(transform: (String) -> String)
+ JsonObject.transformValuestransform: (String) -> String)

@prayansh prayansh requested a review from migs647 August 3, 2021 21:32
migs647
migs647 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@prayansh prayansh merged commit 494e6e5 into main Aug 3, 2021
@prayansh prayansh deleted the pray/helper-fns branch August 3, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@migs647 migs647 migs647 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prayansh @migs647