Allow userId to be nullable on identify for iOS #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prayansh Hi, Im not sure why the CI fails here, it looks like it is a configuration error from the repo, can we merge this? it is pretty important for our company to allow this fast |
danielgomezrico
changed the title
|
@prayansh ping |
|
Hey @wenxi-zeng, any chance this can get merged real quick? |
|
👀 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow that
userIdto be null onidentifyHow should this be manually tested?
Call
identifywithuserIdnull, like:It throws an exception:
Fix #1024
Screenshots or screencasts (if UI/UX change)
On docs the
userIdis defined as optionalhttps://segment.com/docs/connections/sources/catalog/libraries/mobile/ios/#identify