This repository was archived by the owner on Nov 23, 2019. It is now read-only.
Fixes error that occurs when local storage is enabled. #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
suggested changes
Aug 5, 2019
Contributor
fathyb
left a comment
fathyb
left a comment
There was a problem hiding this comment.
Could we add tests to prevent any regressions?
I don't think we usually bump the version in a PR, I think this will prevent the tag v4.2.1 from being created. Could you revert this commit?
bsneed
force-pushed
the
bsneed/fix-localstorage
branch
from
e4e5db7 to
0fc1b58
Compare
Contributor
|
To confirm, did you mean this error occurs when when local storage is disabled? Agree a unit test would be good to have here! |
…rossDomain is disabled.
f2prateek
reviewed
Aug 6, 2019
test/index.test.js
Outdated
| it('identify should not ultimately call getCachedCrossDomainId if crossDomainAnalytics is not enabled', function() { | ||
| var wasCalled = false; | ||
| var oldCrossDomainCheck = segment.isCrossDomainAnalyticsEnabled; | ||
| segment.isCrossDomainAnalyticsEnabled = function() { |
Contributor
There was a problem hiding this comment.
I don't think isCrossDomainAnalyticsEnabled needs to be mocked, it can be disabled with segment.options.crossDomainIdServers = []; (example here).
f2prateek
reviewed
Aug 7, 2019
test/index.test.js
Outdated
| return false; | ||
| }; | ||
| var oldGetCrossDomainId = segment.getCachedCrossDomainId; | ||
| segment.getCachedCrossDomainId = function() { |
Contributor
There was a problem hiding this comment.
Could/should we use sinon for this?
https://sinonjs.org/releases/v7.4.1/spy-call/
segment.options.crossDomainIdServers = [];
var getCachedCrossDomainIdSpy = sinon.spy(segment, "getCachedCrossDomainId");
segment.normalize({});
sinon.assert.notCalled(getCachedCrossDomainIdSpy);
segment.getCachedCrossDomainId.restore();
f2prateek
approved these changes
Aug 7, 2019
fathyb
approved these changes
Aug 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.