This repository was archived by the owner on Nov 27, 2019. It is now read-only.
Updating Rollbar.js versioning #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Esargent01 for taking a stab at this. Per @waltjones, this won't work as expected - #23 is the correct way to do the upgrade. |
|
@Esargent01 I think this can be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the pull request is to update the version of Rollbar that is included with analytics.js. The current version of Rollbar does not support the ability to obfuscate the user's IP address if they opt out of having their information recorded. If we cannot obfuscate the user's IP upon their request then we are not operating within the boundaries of GDPR compliance. This can potentially turn into a serious issue.