Skip to content

change firebase plugin from public to open #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2024
Merged

change firebase plugin from public to open #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c40c068
change firebase plugin from public to open
alanjcharles Feb 14, 2024
14833a6
change update from public to open
alanjcharles Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Sources/SegmentFirebase/FirebaseDestination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ import FirebaseAnalytics
*/

@objc(SEGFirebaseDestination)
public class ObjCFirebaseDestination: NSObject, ObjCPlugin, ObjCPluginShim {
public func instance() -> EventPlugin { return FirebaseDestination() }
}
open class ObjCFirebaseDestination: NSObject, ObjCPlugin, ObjCPluginShim {
public func instance() -> EventPlugin { return FirebaseDestination() }
}

public class FirebaseDestination: DestinationPlugin {
open class FirebaseDestination: DestinationPlugin {
public let timeline = Timeline()
public let type = PluginType.destination
public let key = "Firebase"
Expand All @@ -52,8 +52,8 @@ public class FirebaseDestination: DestinationPlugin {
public init(firebaseOptions: FirebaseOptions? = nil) {
self.firebaseOptions = firebaseOptions
}

public func update(settings: Settings, type: UpdateType) {
open func update(settings: Settings, type: UpdateType) {
// we've already set up this singleton SDK, can't do it again, so skip.
guard type == .initial else { return }

Expand Down