Skip to content

Fix: DHCPv6_am returns Reply instead of Solicit for DHCP6_Request #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Fix: DHCPv6_am returns Reply instead of Solicit for DHCP6_Request #4799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70f15c
Fix: DHCPv6_am returns Reply instead of Solicit for DHCP6_Request
AbhishekPandey1998 Jul 19, 2025
af5a9bc
Fix assert DHCP6_Solicit CI failure
AbhishekPandey1998 Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scapy/layers/dhcp6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ def _include_options(query, answer):
client_duid = p[DHCP6OptClientId].duid
resp = IPv6(src=self.src_addr, dst=req_src)
resp /= UDP(sport=547, dport=546)
resp /= DHCP6_Solicit(trid=trid)
resp /= DHCP6_Reply(trid=trid)
resp /= DHCP6OptServerId(duid=self.duid)
resp /= DHCP6OptClientId(duid=client_duid)

Expand Down
2 changes: 1 addition & 1 deletion test/answering_machines.uts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ assert a.is_request(req)
res = a.make_reply(req)
assert not a.is_request(res)
assert res[UDP].dport == 546
assert res[DHCP6_Solicit]
assert res[DHCP6_Reply]
a.print_reply(req, res)

= WiFi_am
Expand Down
Loading