add type hinting in modules/nmap.py

[nnrepos]

this is a part of #2158 (hinty project).

[codecov]

Codecov Report

Merging #3759 (09f7d51) into master (181bb2f) will decrease coverage by 0.00%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
- Coverage   84.62%   84.61%   -0.01%     
==========================================
  Files         296      296              
  Lines       62084    62094      +10     
==========================================
+ Hits        52536    52543       +7     
- Misses       9548     9551       +3     

Impacted Files	Coverage Δ
scapy/config.py	80.47% <66.66%> (-0.08%)	⬇️
scapy/modules/nmap.py	96.42% <95.00%> (+0.15%)	⬆️
scapy/data.py	87.57% <100.00%> (+0.03%)	⬆️
scapy/arch/windows/__init__.py	67.16% <0.00%> (-0.56%)	⬇️
scapy/supersocket.py	56.58% <0.00%> (-0.30%)	⬇️
scapy/layers/ntp.py	84.55% <0.00%> (-0.28%)	⬇️
scapy/automaton.py	74.04% <0.00%> (-0.12%)	⬇️
scapy/fields.py	91.29% <0.00%> (-0.06%)	⬇️
scapy/sendrecv.py	85.75% <0.00%> (+0.02%)	⬆️
scapy/packet.py	82.58% <0.00%> (+0.06%)	⬆️
... and 3 more

[p-l-]

Hi there,
Thanks for this PR! We try to maintain a code history as clean as possible, so could you please revert the changes that are not needed (e.g., whitespaces)?
Thanks!

[p-l-]

Also, you need to fix the mypy errors:

scapy/data.py:555: error: Missing type parameters for generic type "List"
scapy/config.py:53: error: Module "scapy.data" has no attribute "NmapKnowledgeBase"; maybe "KnowledgeBase"?

[p-l-]

Thanks a lot for this contribution @nnrepos!