[Hinty] Core typing: scapy/pipetools.py & scapy/scapypipes.py #3429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
force-pushed
the
mypy-pipetool
branch
from
d7640fd to
96377b6
Compare
gpotter2
force-pushed
the
mypy-pipetool
branch
from
c031dd5 to
9134491
Compare
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
- Coverage 85.28% 85.23% -0.06%
==========================================
Files 277 277
Lines 57192 57160 -32
==========================================
- Hits 48774 48718 -56
- Misses 8418 8442 +24
|
p-l-
approved these changes
Nov 7, 2021
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
…#3429) * Type pipetool & undo cleanup convert_to * Type forgotten file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #3391
This PR:
pipetools.pyandscapypipes.pyconvert_tomechanism. It's not implemented in A SINGLE scapy packet and is super confusing IMHO. No one ever used this in its lifespan so I don't think it will be missed.... I often think we should not have merged Adds Packet conversion semantics. #1913