Skip to content

Conversation

haggaie
Copy link
Contributor

@haggaie haggaie commented Oct 9, 2020

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests for Python2 and Python3 (using tox or, cd test && ./run_tests_py2, cd test && ./run_tests_py3)
  • If the PR is still not finished, please create a Draft Pull Request

I tried following the instructions for the Hinty project (#2158).

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2858 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   88.20%   88.21%           
=======================================
  Files         254      254           
  Lines       54323    54324    +1     
=======================================
+ Hits        47917    47921    +4     
+ Misses       6406     6403    -3     
Impacted Files Coverage Δ
scapy/contrib/roce.py 94.02% <100.00%> (+0.09%) ⬆️
scapy/arch/windows/__init__.py 68.50% <0.00%> (-0.19%) ⬇️
scapy/layers/tls/automaton_cli.py 76.00% <0.00%> (-0.12%) ⬇️
scapy/layers/inet.py 74.58% <0.00%> (+0.07%) ⬆️
scapy/layers/tls/crypto/cipher_aead.py 81.73% <0.00%> (+0.43%) ⬆️
scapy/layers/tls/record.py 91.59% <0.00%> (+0.81%) ⬆️

@gpotter2 gpotter2 added hacktoberfest-accepted When hacktoberfest PRs are good enough Hinty and removed Hacktoberfest labels Oct 9, 2020
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thanks for the PR

@guedou guedou merged commit 85abf7d into secdev:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted When hacktoberfest PRs are good enough Hinty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants