Skip to content

_check_tcpdump() simpler check and unit tests #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

_check_tcpdump() simpler check and unit tests #2320

merged 1 commit into from
Oct 31, 2019

Conversation

guedou
Copy link
Member

@guedou guedou commented Oct 30, 2019

This PR fixes new issues described in PR #2255

@guedou guedou mentioned this pull request Oct 30, 2019
Merged
p-l-
p-l- requested changes Oct 30, 2019
View reviewed changes
@guedou guedou force-pushed the centos_check_tcpdump branch from 0ccba2c to 4e0a656 Compare October 30, 2019 12:37
@codecov
Copy link

codecov bot commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #2320 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
- Coverage   86.27%   86.26%   -0.01%     
==========================================
  Files         235      235              
  Lines       49948    49948              
==========================================
- Hits        43094    43090       -4     
- Misses       6854     6858       +4
Impacted Files Coverage Δ
scapy/arch/common.py 91.95% <ø> (ø) ⬆️
scapy/autorun.py 78.51% <0%> (-4.14%) ⬇️
scapy/arch/linux.py 77.19% <0%> (-0.24%) ⬇️
scapy/layers/inet6.py 82.07% <0%> (+0.1%) ⬆️

@guedou guedou force-pushed the centos_check_tcpdump branch from 4e0a656 to 50f4de2 Compare October 30, 2019 12:42
p-l-
p-l- requested changes Oct 30, 2019
View reviewed changes
Copy link
Member

@p-l- p-l- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would fix the Appveyor fail

@guedou guedou force-pushed the centos_check_tcpdump branch from 50f4de2 to 277d25f Compare October 30, 2019 15:44
@guedou
Copy link
Member Author

guedou commented Oct 30, 2019

@p-l- ready to be merged.

@p-l- p-l- merged commit eae88df into secdev:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-l- p-l- p-l- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guedou @p-l-