This repository was archived by the owner on Dec 8, 2023. It is now read-only.
Address CORS-related issues with external images #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issues Add CrossOrigin property and dynamic datetime when fetching image
…stall Add a prepare script to automatically build package after npm installing
…stall Fix prepare script to run build-bundle instead of build
…stall Add .npmignore to override .gitignore settings when running install scripts
…amples with new vue's linter rules; Update Changelog
…stall Update README.md to address external images CORS issues and to fix examples with new vue's linter rules; Update Changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
While using this package I have noticed the second caveat listed in the README.md, referring that the package did not handle well remote image fetching.
I found the culprit and added some changes that can help solve that - if the external image does correctly provide the header
Access-Control-Allow-Originin the response headers.I have updated the README.md as well with further instructions.
Let me know what do you think of this.