Add relocation hooks #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
eddumelendez,
helpermethod and
marc0der
marc0der
approved these changes
Aug 30, 2022
|
Related to this one, I'll begin decommissioning the pre-hooks since they are no longer used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is for sdkman-cli to skip the post-hooks after downloading the artifacts, perform the checksum, expand the archive (unzip, tar), and move the files to its final destination (under
${SDKMAN_CANDIDATES_DIR}/${candidate}/${version}).These 'relocation' hooks will be executed at the very end of the pipeline, and will shuffle things around for a very small number of binaries (mainly JDK for OSX and JMC).
This logic moves the logic from the post hooks we have today to a later stage, so we can avoid re-packaging the artifacts (which breaks checksumming).