Skip to content

1/3: Remove post-install hook #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 27, 2022
Merged

1/3: Remove post-install hook #1155

merged 4 commits into from
Dec 27, 2022

Conversation

hgeraldino
Copy link
Contributor

First PR: remove post-install hook

@hgeraldino hgeraldino changed the title Remove post-install hook 1/3: Remove post-install hook Dec 18, 2022
@hgeraldino hgeraldino marked this pull request as ready for review December 19, 2022 22:37
@hgeraldino hgeraldino requested a review from a team December 19, 2022 22:38
@hgeraldino hgeraldino self-assigned this Dec 19, 2022
marc0der
marc0der reviewed Dec 22, 2022
View reviewed changes
marc0der
marc0der reviewed Dec 22, 2022
View reviewed changes
marc0der
marc0der requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we can rip out the nasty pre-installation hooks too, since we don't use them anymore.

@hgeraldino
Copy link
Contributor Author

Looking good! I think we can rip out the nasty pre-installation hooks too, since we don't use them anymore.

Removed

@hgeraldino hgeraldino merged commit b6d270a into checksums Dec 27, 2022
@hgeraldino hgeraldino deleted the remove-posthooks branch December 27, 2022 01:21
@hgeraldino hgeraldino mentioned this pull request Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc0der marc0der marc0der approved these changes

@helpermethod helpermethod Awaiting requested review from helpermethod

@eddumelendez eddumelendez Awaiting requested review from eddumelendez

Assignees

@hgeraldino hgeraldino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hgeraldino @marc0der