Skip to content

Conversation

@Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Apr 1, 2025

After 1.0 many parts of the document became outdated.
This PR updates them, and simplifies some stuff (for example, there is no longer a difference between instructions for minor / major / patch release).

Fixes: #1264

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested review from muzarski and wprzytula April 1, 2025 14:06
@Lorak-mmk
Copy link
Collaborator Author

Probably the easiest and best way to review is to read the whole new version of the document, instead of looking at the diff @wprzytula @muzarski

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

cargo semver-checks found no API-breaking changes in this PR.
Checked commit: 6f75b3e

@Lorak-mmk Lorak-mmk self-assigned this Apr 1, 2025
@Lorak-mmk Lorak-mmk added this to the 1.1.0 milestone Apr 1, 2025
@wprzytula
Copy link
Collaborator

wprzytula commented Apr 1, 2025

CI has failed with an interesting error message that I haven't seen before:

thread 'session::test_views_in_schema_info' panicked at scylla/tests/integration/session.rs:2484:114:
LastAttemptError(DbError(Invalid, "Materialized views are not supported on base tables with tablets"))

@piodul
Copy link
Collaborator

piodul commented Apr 1, 2025

CI has failed with an interesting error message that I haven't seen before:

thread 'session::test_views_in_schema_info' panicked at scylla/tests/integration/session.rs:2484:114:
LastAttemptError(DbError(Invalid, "Materialized views are not supported on base tables with tablets"))

Materialized views + tablets combination is not supported in 2025.1 (it is going to be supported in 2025.2). Did you bump scylla version in CI recently?

@wprzytula
Copy link
Collaborator

wprzytula commented Apr 1, 2025

CI has failed with an interesting error message that I haven't seen before:

thread 'session::test_views_in_schema_info' panicked at scylla/tests/integration/session.rs:2484:114:
LastAttemptError(DbError(Invalid, "Materialized views are not supported on base tables with tablets"))

Materialized views + tablets combination is not supported in 2025.1 (it is going to be supported in 2025.2). Did you bump scylla version in CI recently?

We just fetch the latest available docker image. I can see there's been an upload 8 hrs ago: 2025.1.0.

@Lorak-mmk
Copy link
Collaborator Author

Materialized views + tablets combination is not supported in 2025.1 (it is going to be supported in 2025.2). Did you bump scylla version in CI recently?

I don't get it, was the support dropped? We did not get such an error with 6.2.

@Lorak-mmk Lorak-mmk force-pushed the maintenance-procedures branch from 41aa8b6 to 830694e Compare April 2, 2025 11:01
@wprzytula wprzytula self-requested a review April 2, 2025 12:01
@Lorak-mmk Lorak-mmk force-pushed the maintenance-procedures branch from 830694e to 773129c Compare April 2, 2025 13:14
@Lorak-mmk Lorak-mmk requested a review from wprzytula April 2, 2025 13:14
wprzytula
wprzytula previously approved these changes Apr 2, 2025
Copy link
Collaborator

@wprzytula wprzytula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This document helps a lot.

@Lorak-mmk Lorak-mmk requested a review from muzarski April 2, 2025 14:18
@Lorak-mmk Lorak-mmk merged commit d536e41 into scylladb:main Apr 2, 2025
12 checks passed
@Lorak-mmk Lorak-mmk deleted the maintenance-procedures branch April 2, 2025 17:31
@wprzytula wprzytula mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update maintenance procedures

4 participants