Skip to content

Conversation

@muzarski
Copy link
Contributor

We changed the return error type of this method, but forgot to update the docs.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

We changed the return error type of this method, but forgot to update
the docs.
@muzarski muzarski requested a review from Lorak-mmk March 19, 2025 15:20
@github-actions
Copy link

cargo semver-checks found no API-breaking changes in this PR.
Checked commit: 48effd2

@Lorak-mmk Lorak-mmk merged commit f6aab62 into scylladb:main Mar 19, 2025
13 checks passed
@Lorak-mmk Lorak-mmk added this to the 1.1.0 milestone Mar 19, 2025
@muzarski muzarski deleted the fix-schema-agreement-timeout-docs branch March 19, 2025 15:45
@wprzytula wprzytula mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants