render_labels and render_shapes now scan for and respect xyz_colors in adata.uns
#492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 83.89% 83.38% -0.51%
==========================================
Files 8 8
Lines 1819 1884 +65
==========================================
+ Hits 1526 1571 +45
- Misses 293 313 +20
🚀 New features to boost your workflow:
|
timtreis
added
enhancement
Sonja-Stockhaus
approved these changes
Sep 24, 2025
| sdata_blobs["other_table"].obs["category"] = sdata_blobs["other_table"].obs["category"].astype("category") | ||
| sdata_blobs["other_table"].uns["category_colors"] = ["#800080", "#008000", "#FFFF00"] # purple, green ,yellow | ||
|
|
||
| sdata_blobs.pl.render_labels("blobs_labels", color="category").pl.show() |
There was a problem hiding this comment.
Correct me if I'm wrong but shouldn't this all be about shapes and not plotting the labels again?
|
|
||
| # Validate na_color format | ||
| if "#" not in str(na_color): | ||
| logger.warning("Expected `na_color` to be a hex color, converting...") |
There was a problem hiding this comment.
hmm, do we really expect that the user passes a hex?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.