-
Notifications
You must be signed in to change notification settings - Fork 626
[FIX] Compatible with current prover (before 0.5.6) #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates pinned git revisions for three zkVM workspace dependencies in Cargo.toml and bumps the internal version tag from v4.5.44 to v4.5.45 in common/version/version.go. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Cargo.toml (1)
20-22
: Prefer full 40-char SHA forrev
to avoid future ambiguity.Short SHAs generally work but can become ambiguous over time; using the full commit hash improves robustness and auditability. No functional change required.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
Cargo.lock
is excluded by!**/*.lock
crates/gpu_override/Cargo.lock
is excluded by!**/*.lock
📒 Files selected for processing (2)
Cargo.toml
(1 hunks)common/version/version.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: tests
🔇 Additional comments (4)
Cargo.toml (2)
20-22
: LGTM: pinned zkVM suite to a single commit across prover/verifier/types.Consistent rev across the three crates matches the PR goal of restoring compatibility with pre-0.5.6 proofs.
20-22
: No action needed: Manifests and lockfile are consistent
Manifests reference rev ad0efe7 for all three scroll-zkvm modules, and Cargo.lock pins that same commit (long SHA ad0efe750d5f03781f28037c312e50400ac22a8d) with no other overrides.common/version/version.go (2)
8-8
: Version tag bump to v4.5.45 looks good.Matches the dependency tweak and will surface in the composite Version string at runtime.
8-8
: Confirm release/process alignment.After merge, ensure a corresponding Git tag/release is cut for v4.5.45 and that CI injects non-default ZkVersion (prover/openvm commit-ids) so production builds don’t report “000000-000000”.
This PR updated the dep of zkvm-prover with a trivial fixing so it can be compatible with the proof send from current prover being deployed (before 0.5.6)
Updating in zkvm-prover: scroll-tech/zkvm-prover#180
Summary by CodeRabbit