Skip to content

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jul 29, 2025

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

This PR update dependency go-ethereum version to commit bd8f141bb3e986cac341f20397e0d35c88772327, which fix issue: blob client beacon node do http request without context.
In this case bridge-history-api won't stuck at the beacon node blob request function.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Updated a core dependency to a newer version.
    • Bumped the application version to v4.5.36.

@yiweichi yiweichi requested a review from colinlyguo July 29, 2025 13:48
Copy link

coderabbitai bot commented Jul 29, 2025

Walkthrough

The changes update the github.com/scroll-tech/go-ethereum dependency to a newer version in the bridge-history-api/go.mod file and increment the version tag in common/version/version.go from "v4.5.35" to "v4.5.36". No other code or logic was modified.

Changes

Cohort / File(s) Change Summary
Go-Ethereum Dependency Update
bridge-history-api/go.mod
Bumped github.com/scroll-tech/go-ethereum dependency version in both require and replace directives.
Version Tag Update
common/version/version.go
Updated version tag string from "v4.5.35" to "v4.5.36".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • georgehao
  • Thegaram

Poem

Another hop, another leap,
Our version climbs, no time for sleep!
Dependencies fresh, the code is neat,
v4.5.36 is now complete.
With every bump, the project grows—
A happy rabbit, twitching nose! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d62f8e and 08b6f13.

⛔ Files ignored due to path filters (2)
  • bridge-history-api/go.sum is excluded by !**/*.sum
  • go.work.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • bridge-history-api/go.mod (1 hunks)
  • common/version/version.go (1 hunks)
🔇 Additional comments (3)
bridge-history-api/go.mod (2)

14-15: Dependency bump looks consistent – remember to commit the regenerated go.sum.

The pseudo-version was bumped in both require and replace, so the module graph will resolve cleanly.
After running go mod tidy / go test ./... locally, ensure the resulting go.sum diff (and any indirect version changes) are added to the PR; otherwise CI or reproducible builds may fail.


21-21: Double-check the hot-fix comment still applies to the new commit.

The in-place replace is retained with the same comment (“header hash incompatibility hot-fix”).
Verify that commit bd8f141bb3e9 still contains that patch or an equivalent fix; if upstream merged it differently, the comment may no longer be accurate and the replace could be removed.

common/version/version.go (1)

8-8: Version tag updated — LGTM.

Tag bump to v4.5.36 aligns with the dependency upgrade and follows semantic monotonicity. Nothing else to address here.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-bridge-history-go-ethereum-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yiweichi yiweichi requested a review from georgehao July 29, 2025 13:50
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.55%. Comparing base (6d62f8e) to head (08b6f13).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1713      +/-   ##
===========================================
- Coverage    39.62%   39.55%   -0.07%     
===========================================
  Files          237      237              
  Lines        18970    18999      +29     
===========================================
  Hits          7516     7516              
- Misses       10714    10743      +29     
  Partials       740      740              
Flag Coverage Δ
bridge-history-api 8.08% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yiweichi yiweichi merged commit 4bfcd35 into develop Jul 30, 2025
6 checks passed
@yiweichi yiweichi deleted the update-bridge-history-go-ethereum-package branch July 30, 2025 06:32
@coderabbitai coderabbitai bot mentioned this pull request Oct 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants