Skip to content

Conversation

colinlyguo
Copy link
Contributor

@colinlyguo colinlyguo commented Oct 7, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Summary by CodeRabbit

  • New Features

    • Updated dependencies for improved functionality and compatibility across multiple modules.
    • Introduced new indirect dependencies that may enhance performance and features.
  • Bug Fixes

    • Resolved issues related to outdated dependencies by updating to more stable versions.
  • Chores

    • Removed obsolete dependencies to streamline the codebase and reduce potential conflicts.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 32.24490% with 166 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (f2a656d) to head (113dea1).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
rollup/internal/utils/utils.go 0.00% 111 Missing ⚠️
rollup/internal/controller/relayer/l2_relayer.go 64.00% 15 Missing and 3 partials ⚠️
coordinator/internal/orm/batch.go 0.00% 8 Missing ⚠️
coordinator/internal/orm/chunk.go 0.00% 8 Missing ⚠️
...llup/internal/controller/watcher/batch_proposer.go 75.00% 4 Missing and 1 partial ⚠️
rollup/internal/controller/watcher/l2_watcher.go 37.50% 5 Missing ⚠️
rollup/internal/orm/batch.go 50.00% 4 Missing and 1 partial ⚠️
rollup/internal/orm/chunk.go 60.00% 3 Missing and 1 partial ⚠️
...llup/internal/controller/watcher/chunk_proposer.go 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1530      +/-   ##
===========================================
+ Coverage    51.71%   52.84%   +1.12%     
===========================================
  Files          157      157              
  Lines        13054    12641     -413     
===========================================
- Hits          6751     6680      -71     
+ Misses        5716     5382     -334     
+ Partials       587      579       -8     
Flag Coverage Δ
bridge-history-api 71.16% <ø> (ø)
common 44.60% <ø> (ø)
coordinator 17.13% <0.00%> (-0.09%) ⬇️
database 42.48% <ø> (ø)
rollup 59.11% <34.49%> (+3.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Oct 7, 2024
georgehao
georgehao previously approved these changes Oct 10, 2024
@colinlyguo colinlyguo requested a review from georgehao October 20, 2024 16:13
georgehao
georgehao previously approved these changes Oct 20, 2024
jonastheis
jonastheis previously approved these changes Oct 21, 2024
georgehao
georgehao previously approved these changes Oct 21, 2024
@colinlyguo colinlyguo dismissed stale reviews from georgehao and jonastheis via 113dea1 October 21, 2024 13:48
@colinlyguo colinlyguo merged commit 233fff0 into develop Oct 22, 2024
18 checks passed
@colinlyguo colinlyguo deleted the refactor-da-codec branch October 22, 2024 03:13
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2024
3 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 16, 2025
13 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 26, 2025
3 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 19, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump-version Bump the version tag for deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants